Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add O2sol functions #26

Merged
merged 3 commits into from
Jun 6, 2018
Merged

Add O2sol functions #26

merged 3 commits into from
Jun 6, 2018

Conversation

DocOtak
Copy link
Contributor

@DocOtak DocOtak commented Jun 5, 2018

With #23 merged, there appears to be a clearer path for adding missing functions. As such, here is my first attempt to add some functions, specifically two of the O2 gas solubility functions. I've also added the check functions and data.

These functions were directly ported from the matlab version, including comments/documentation. The functions were placed in the c source alphabetically by function name.

@efiring
Copy link
Member

efiring commented Jun 6, 2018

Thank you, I think this is almost ready. Please use 4-space indentation in the C function bodies, and remove the trailing whitespace.

@DocOtak
Copy link
Contributor Author

DocOtak commented Jun 6, 2018

Thanks @efiring, I've indented and think I squashed all the trailing whitespace. Shall I attempt a start at a CONTRIBUTING file for future reference?

@efiring efiring merged commit e77ea24 into TEOS-10:master Jun 6, 2018
@efiring
Copy link
Member

efiring commented Jun 6, 2018

@DocOtak see #27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants