Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p_from_z and z_from_p: add two arguments #32

Merged
merged 2 commits into from
Apr 22, 2019
Merged

Conversation

efiring
Copy link
Member

@efiring efiring commented Apr 19, 2019

The two arguments, geo_strf_dyn_height and sea_surface_geopotential,
are not used internally and are optional in the Matlab and Fortran
versions. They will also be optional in the Python version. C support
for optional arguments is less straightforward than in the other
languages, so we stick with the simple 4-argument signature instead.

The two arguments, geo_strf_dyn_height and sea_surface_geopotential,
are not used internally and are optional in the Matlab and Fortran
versions.  They will also be optional in the Python version.  C support
for optional arguments is less straightforward than in the other
languages, so we stick with the simple 4-argument signature instead.
@DocOtak
Copy link
Contributor

DocOtak commented Apr 19, 2019

Oh my... look at all that trailing whitespace that is all my fault.

This PR looks ok to me, but I probably won't have an opportunity to test myself (currently on the TGT).

@efiring
Copy link
Member Author

efiring commented Apr 19, 2019

@DocOtak Thanks for taking a look from your very remote location!
I ran the standard test, which I modified to include the new args set to zero. Presently there are no tests for the optional args, either in C or in Matlab; I can make a test for that in the Python version.

@efiring efiring merged commit 95a9cae into TEOS-10:master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants