Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: reformat gsw_saar.c #37

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

efiring
Copy link
Member

@efiring efiring commented Jul 7, 2021

Dan Kelley pointed out that there were 4 indendation warnings; in
addition, the indentation was highly inconsistent. This commit
uses the stock vscode C reformatting function to use uniform 4-space
indentation. I also removed a duplicated macro, added a blank
line after each one-line "if" block, and rearranged one loop
for better readability.

Dan Kelley pointed out that there were 4 indendation warnings; in
addition, the indentation was highly inconsistent.  This commit
uses the stock vscode C reformatting function to use uniform 4-space
indentation.  I also removed a duplicated macro, added a blank
line after each one-line "if" block, and rearranged one loop
for better readability.
@ocefpaf
Copy link
Member

ocefpaf commented Jul 14, 2021

Is this something worth enforcing with a linter or something? There is probably a pre-commit for that (but I did not check).

@efiring
Copy link
Member Author

efiring commented Jul 14, 2021

I don't think I want to get into massive reformatting and format policing quite yet. gsw_saar.c is very short compared to the remainder, so I didn't feel quite so bad about the churn. Maybe just start with hooks to check for end-of-line whitespace and EOF newline.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 14, 2021

Maybe just start with hooks to check for end-of-line whitespace and EOF newline.

Done in #45 but I would merge this one first to avoid conflicts. Let me know if you are done here so we can merge it.

@efiring
Copy link
Member Author

efiring commented Jul 14, 2021

Oops! I merged #45 first. I will close and reopen to run the check, and fix the file if needed.

@efiring efiring closed this Jul 14, 2021
@efiring efiring reopened this Jul 14, 2021
@efiring efiring merged commit bad2c9e into TEOS-10:master Jul 14, 2021
@efiring efiring deleted the reformat_saar branch July 14, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants