Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell pre-commit #42

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Add codespell pre-commit #42

merged 3 commits into from
Jul 13, 2021

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jul 13, 2021

@efiring this is a "harmless" GitHub Action b/c we need one to get it to run in all PRs. Once this is merged I'll work on getting #41 into shape.

Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple typos in the attempted correction...

! Salinity, SA_final, and Conservative Temperature, CT_final, of the
! interstitial seawater phase are also returned. This code assumes that
! there is no dissolved air in the seawater (that is, saturation_fraction
! is assumed to be zero thoughout the code).
! is assumed to be zero thorughout the code).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a typo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why codespell suggested that change :-/ I probably added that to its dict.

@@ -7559,7 +7559,7 @@ gsw_pt_from_t(double sa, double t, double p, double p_ref)
dentropy_dt = gsw_cp0/((gsw_t0 + pt)*(1.0-0.05*(1.0 - sa/gsw_sso)));
true_entropy_part = gsw_entropy_part(sa,t,p);
for (no_iter=1; no_iter <= 2; no_iter++) {
pt_old = pt;
pt_old = pt;temperatur
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glitch here, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self, do not edit files with the baby on your lap.

@ocefpaf ocefpaf requested a review from efiring July 13, 2021 22:35
@efiring efiring merged commit 397907a into TEOS-10:master Jul 13, 2021
@ocefpaf ocefpaf deleted the add_GHA branch July 13, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants