Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Pin dicer to v0.3.1 #181

Merged
merged 1 commit into from Aug 24, 2022
Merged

API: Pin dicer to v0.3.1 #181

merged 1 commit into from Aug 24, 2022

Conversation

XeR
Copy link
Contributor

@XeR XeR commented Aug 24, 2022

Current fix required to edit the lock file by hand.
This commit adds a "resolutions" key to the package.json file.
This pins this specific dependency to version 0.3.1 without using dubious hacks.

More info about this feature:
https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/

On a different topic : can you rebase PR instead of merging them ? (Click on the downward-pointing arrow before merging)
This makes a prettier git history

Current fix required to edit the lock file by hand.
This commit adds a "resolutions" key to the package.json file.
This pins this specific dependency to version 0.3.1 without using dubious hacks.

More info about this feature:
https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/
@XeR XeR requested a review from JJ-8 August 24, 2022 18:58
Copy link
Collaborator

@JJ-8 JJ-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to hear that there is a proper solution for this.

On a different topic : can you rebase PR instead of merging them ? (Click on the downward-pointing arrow before merging)
This makes a prettier git history

Sure! I am used to explicit merges, but rebasing is also fine.

@JJ-8 JJ-8 merged commit 44d9f22 into TFNS:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants