Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Discord integration checks to frontend. #296

Merged
merged 10 commits into from
Jul 18, 2024
Merged

Add Discord integration checks to frontend. #296

merged 10 commits into from
Jul 18, 2024

Conversation

daanbreur
Copy link
Contributor

Implementation of issue #292.

Adds a warning telling you the integration has been disabled

image

image

@daanbreur daanbreur marked this pull request as ready for review July 17, 2024 08:40
@daanbreur daanbreur marked this pull request as draft July 17, 2024 08:44
JJ-8
JJ-8 requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@JJ-8 JJ-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some small comments, see the review.

front/src/pages/Settings.vue Show resolved Hide resolved
front/src/components/CTF/Guests.vue Outdated Show resolved Hide resolved
api/migrations/54-add-discord-integration-enabled.sql Outdated Show resolved Hide resolved
api/src/index.ts Show resolved Hide resolved
front/src/pages/Settings.vue Outdated Show resolved Hide resolved
front/src/components/CTF/Guests.vue Outdated Show resolved Hide resolved
@JJ-8
Copy link
Collaborator

JJ-8 commented Jul 17, 2024

The build also fails due to the GraphQL schema file not being up to date. I can give it an attempt too of creating this file since you already mentioned on Discord that you had issues with this. Something is going wrong at least.

@daanbreur
Copy link
Contributor Author

The build also fails due to the GraphQL schema file not being up to date. I can give it an attempt too of creating this file since you already mentioned on Discord that you had issues with this. Something is going wrong at least.

That would be great, we are using all the correct versions so idk whats going on. 🤷

@daanbreur daanbreur requested a review from JJ-8 July 17, 2024 09:48
@daanbreur daanbreur marked this pull request as ready for review July 17, 2024 10:15
@daanbreur
Copy link
Contributor Author

Seems like running it under a linux virtualmachine fixed the codegen issue, i have no clue what the caused the bug itself tho.

@daanbreur daanbreur marked this pull request as draft July 17, 2024 11:05
@daanbreur daanbreur marked this pull request as ready for review July 17, 2024 11:32
@daanbreur
Copy link
Contributor Author

image

image

Fixed user_admin permissions in the latest commit by revoking their table wide update then granting them the columns seperately

@daanbreur daanbreur changed the title [WIP] Add Discord integration checks to frontend. Add Discord integration checks to frontend. Jul 17, 2024
JJ-8
JJ-8 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@JJ-8 JJ-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and works as expected. Code looks good to me. Thank you for your contribution!

@JJ-8 JJ-8 merged commit 6238a5d into TFNS:main Jul 18, 2024
4 checks passed
@JJ-8 JJ-8 mentioned this pull request Jul 18, 2024
Closed
@daanbreur
Copy link
Contributor Author

Your welcome. Just now I did notice the generated GraphQL model is still a bit off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JJ-8 JJ-8 JJ-8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daanbreur @JJ-8