Ingestion: Replace multiprocessing.Pool
with concurrent.futures.ProcessPoolExecutor
#202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
multiprocessing.Pool
withconcurrent.futures.ProcessPoolExecutor
for improved exception handling and code simplification. The main issue addressed is the hanging of the ingestion process due to unhandled exceptions in subprocesses.The changes include:
trace_worker_map
andheader_scan_worker_map
wrapper functions in_workers.py
, as they are no longer necessary.blocked_io.py
to useProcessPoolExecutor.map
instead ofPool.starmap
. Theparallel_inputs
iterator has been moved directly into the map call.parsers.py
to useProcessPoolExecutor
instead ofPool
. The executor.map method is now used, with theheader_scan_worker
function and the input iterators passed directly as arguments.