Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoShotWrap grid override #338

Merged
merged 16 commits into from
Mar 10, 2024
Merged

Conversation

markspec
Copy link
Contributor

This allows ingestion with gun indexed by unwrapping shot_point for shot_lines.

@markspec markspec changed the title AutoShopWrap grid override AutoShotWrap grid override Jan 24, 2024
@markspec markspec marked this pull request as ready for review January 24, 2024 17:54
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: Patch coverage is 92.63158% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.59%. Comparing base (c3ba558) to head (c5acee3).
Report is 9 commits behind head on main.

Files Patch % Lines
src/mdio/segy/geometry.py 86.00% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   85.30%   86.59%   +1.28%     
==========================================
  Files          46       48       +2     
  Lines        2219     2440     +221     
  Branches      306      353      +47     
==========================================
+ Hits         1893     2113     +220     
+ Misses        281      274       -7     
- Partials       45       53       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tasansal
Copy link
Collaborator

tasansal commented Feb 8, 2024

Hi @markspec, can we add at least 1 test for each configuration?

@tasansal
Copy link
Collaborator

tasansal commented Feb 8, 2024

Closes #336

@tasansal tasansal linked an issue Feb 8, 2024 that may be closed by this pull request
@tasansal tasansal added the enhancement New feature or request label Feb 8, 2024
@markspec
Copy link
Contributor Author

@tasansal , please can you look at this?

  1. The tests pass in my devcontainer with 3.12.
  2. The doc build complains about an indentation error but I can'f see any issues on the reported line.

src/mdio/converters/segy.py Show resolved Hide resolved
src/mdio/segy/geometry.py Show resolved Hide resolved
poetry.lock Outdated Show resolved Hide resolved
src/mdio/converters/segy.py Show resolved Hide resolved
tests/integration/conftest.py Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
src/mdio/segy/geometry.py Outdated Show resolved Hide resolved
tests/integration/conftest.py Outdated Show resolved Hide resolved
@tasansal
Copy link
Collaborator

tasansal commented Mar 8, 2024

@markspec approved but there's a test conflict; please fix so we can merge. thanks!

@tasansal tasansal merged commit 40ed5e0 into TGSAI:main Mar 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved pre-stack indexing for 3D towed streamer data
3 participants