Partial implementation of reactions #154 #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkryl
reviewed
Jul 2, 2022
| this.reactionInfo = findReactionInfo(reaction.reaction, tdlib); | ||
| } | ||
| private TdApi.MessageReaction reaction; | ||
| private TdApi.Reaction reactionInfo; |
There was a problem hiding this comment.
I can notice that PR has some issues with whitespaces:
- Double whitespace before field type
- Missing whitespace after
for,if, etc - Double whitespace before method return type
Since whitespaces fixes are minor and do not affect the build in any way, you are allowed to submit the commit that addresses them before results announcements.
Also you may find these suggestions useful:
https://t.me/tgx_dev/1568
https://t.me/tgx_dev/1561
There was a problem hiding this comment.
Some Android Studio issue with formatting, probably...
I forgeted to text what things was completed.
- Reaction display for bubble/unbubble mode. Bubble mode partly broken, it has wrong positions sometime, but i hate bubble (I'm sure you understand me) mode so i didn't fixed it.
- Ability to pass animation on message: add existed reaction by tapping on reaction in message or non-existed from context menu. But without most of animations.
2.1) Also, as you say https://t.me/tgx_dev/734 here. I display tooltip if tdlib return error while passing reaction. - User can see passed reactions, it partly completed... User can see it only for outgoing messages
Bigcatcatone
approved these changes
Jul 4, 2022
|
Thank you for participating. Check out the results for the first round: 🏆 Telegram X Android Competition, Round 1 Results. Closing this pull request just to keep the pull request list clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Я сделаль...