Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starting room with files fails if scalelite server is used #1046

Merged

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Apr 30, 2024

Fixes #1045

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Fix starting room with files fails if scalelite server is used
  • Bump Dependencies

Other information

Order of calling the Laravel HTTP Client caused an invalid Content-Type causing scalelite to fail the request

@SamuelWei SamuelWei marked this pull request as ready for review May 2, 2024 07:38
@SamuelWei SamuelWei merged commit cee297f into 2.x May 2, 2024
5 checks passed
SamuelWei added a commit that referenced this pull request May 2, 2024
Fix starting room with files fails if scalelite server is used and dump Dependencies
SamuelWei added a commit that referenced this pull request May 2, 2024
Fix starting room with files fails if scalelite server is used and dump Dependencies
@SamuelWei SamuelWei deleted the 1045-starting-room-with-files-fails-if-scalelite-server-is-used branch June 6, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant