-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict room type access #127
Conversation
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
============================================
+ Coverage 91.31% 91.36% +0.05%
- Complexity 540 557 +17
============================================
Files 152 153 +1
Lines 3016 3081 +65
Branches 183 184 +1
============================================
+ Hits 2754 2815 +61
- Misses 200 204 +4
Partials 62 62
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I think we also need to add the permission inheritance for roomTypes and roles, so the user editing the roomTypes can load the roles.
Fixes #98
Type (Highlight the corresponding type)
Checklist
Changes