Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meeting stats and attendance reports #134

Merged
merged 42 commits into from
Jul 2, 2021
Merged

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Apr 26, 2021

Fixes #133

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current masters head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Added more efficent way to log attendance
  • Added room setting to enable attendance logging
  • Added UI to room view to see all (current and previous) meetings of a room, the usage statistics and attendance
  • Fixed start time in the list of currently running meetings not adjusted to the user's time zone setting
  • Added application settings to enable/disable server and meeting usage statistics and set retention periods
  • Added application setting to allow attendance logging and set retention period
  • Added note and agreement checkbox for users/guests to join/start a meeting with logged attendance

Other information

@SamuelWei SamuelWei added the enhancement New feature or request label Apr 26, 2021
@SamuelWei SamuelWei self-assigned this Apr 26, 2021
@SamuelWei SamuelWei added this to In progress in PILOS Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #134 (7c667cc) into master (28156c3) will increase coverage by 0.96%.
The diff coverage is 95.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #134      +/-   ##
============================================
+ Coverage     91.77%   92.74%   +0.96%     
- Complexity      584      644      +60     
============================================
  Files           154      165      +11     
  Lines          3235     3472     +237     
  Branches        184      192       +8     
============================================
+ Hits           2969     3220     +251     
+ Misses          204      184      -20     
- Partials         62       68       +6     
Impacted Files Coverage Δ
app/Console/Kernel.php 37.50% <0.00%> (-12.50%) ⬇️
app/MeetingStat.php 0.00% <ø> (ø)
app/Room.php 98.46% <ø> (ø)
resources/js/charts/LineChart.js 0.00% <0.00%> (ø)
resources/js/components/Room/FileComponent.vue 87.83% <0.00%> (ø)
resources/js/components/Room/SettingsComponent.vue 86.20% <ø> (ø)
resources/js/plugins/Dayjs.js 0.00% <0.00%> (ø)
resources/js/store/modules/session.js 79.31% <0.00%> (-2.84%) ⬇️
resources/js/views/meetings/Index.vue 94.73% <ø> (ø)
resources/js/views/rooms/View.vue 67.92% <75.00%> (+23.02%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28156c3...7c667cc. Read the comment docs.

@SamuelWei SamuelWei marked this pull request as ready for review July 1, 2021 17:18
@SamuelWei SamuelWei requested a review from dsst95 July 1, 2021 17:24
Copy link
Contributor

@dsst95 dsst95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first part of the review. So you can already make fixes or answer my questions.

CHANGELOG.md Outdated Show resolved Hide resolved
app/Http/Requests/StartJoinMeeting.php Outdated Show resolved Hide resolved
resources/js/lang/de/rooms.js Show resolved Hide resolved
resources/js/lang/de/rooms.js Outdated Show resolved Hide resolved
resources/js/lang/en/rooms.js Outdated Show resolved Hide resolved
app/Http/Requests/UpdateSetting.php Show resolved Hide resolved
app/Server.php Show resolved Hide resolved
app/Server.php Show resolved Hide resolved
@SamuelWei SamuelWei requested a review from dsst95 July 2, 2021 13:00
@SamuelWei SamuelWei merged commit 950c482 into master Jul 2, 2021
@SamuelWei SamuelWei deleted the 133-add-meeting-stats branch July 2, 2021 13:19
@SamuelWei SamuelWei moved this from In progress to Done in PILOS Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
PILOS
Done
Development

Successfully merging this pull request may close these issues.

Add meeting stats and attendance reports
2 participants