Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shibboleth #139

Closed
wants to merge 8 commits into from
Closed

Add shibboleth #139

wants to merge 8 commits into from

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented May 7, 2021

Fixes #20

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current masters head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Add shibboleth authentication
  • Make LDAP login configurable (enabled/disabled)

Other information

Add this to the section of the vhost apache config:

<Location />
    AuthType shibboleth
    Require shibboleth
</Location>

<Location /shibboleth>
    AuthType shibboleth
    ShibRequestSetting requireSession 1
    Require valid-user
</Location>

@SamuelWei SamuelWei self-assigned this May 7, 2021
@SamuelWei SamuelWei added this to In progress in PILOS May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #139 (0f75708) into master (5a95dc7) will decrease coverage by 4.36%.
The diff coverage is 0.00%.

❗ Current head 0f75708 differs from pull request most recent head 1bfcb4a. Consider uploading reports for the commit 1bfcb4a to get more accurate results

@@             Coverage Diff              @@
##             master     #139      +/-   ##
============================================
- Coverage     94.72%   90.36%   -4.37%     
+ Complexity      732      543     -189     
============================================
  Files           174      153      -21     
  Lines          3925     3040     -885     
  Branches        246      182      -64     
============================================
- Hits           3718     2747     -971     
- Misses          178      231      +53     
- Partials         29       62      +33     
Impacted Files Coverage Δ
app/Http/Controllers/auth/ShibbolethController.php 0.00% <0.00%> (ø)
resources/js/views/rooms/View.vue 44.89% <0.00%> (-44.52%) ⬇️
resources/js/i18n.js 73.68% <0.00%> (-18.63%) ⬇️
resources/js/views/settings/Application.vue 75.86% <0.00%> (-8.04%) ⬇️
resources/js/components/Room/NewRoomComponent.vue 80.76% <0.00%> (-7.70%) ⬇️
resources/js/components/Room/FileComponent.vue 87.83% <0.00%> (-7.41%) ⬇️
resources/js/views/PasswordReset.vue 93.33% <0.00%> (-6.67%) ⬇️
...esources/js/components/RoomType/RoomTypeSelect.vue 90.47% <0.00%> (-5.18%) ⬇️
resources/js/views/settings/users/View.vue 89.91% <0.00%> (-4.03%) ⬇️
resources/js/views/settings/users/Index.vue 85.71% <0.00%> (-3.76%) ⬇️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a95dc7...1bfcb4a. Read the comment docs.

@SamuelWei SamuelWei mentioned this pull request Jul 19, 2022
…t-shibboleth

# Conflicts:
#	app/Http/Kernel.php
#	app/Http/Resources/ApplicationSettings.php
#	composer.json
#	routes/api.php
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.


<portType name="LogoutNotificationPortType">
<operation name="LogoutNotification">
<input message="getLogoutNotificationRequest"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

@SamuelWei SamuelWei added enhancement New feature or request help wanted Extra attention is needed labels Oct 26, 2022
@SamuelWei
Copy link
Collaborator Author

Closed in favor of #336

@SamuelWei SamuelWei closed this Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
PILOS
In progress
Development

Successfully merging this pull request may close these issues.

Implement shibboleth sso authentication
1 participant