-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shibboleth #139
Add shibboleth #139
Conversation
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
============================================
- Coverage 94.72% 90.36% -4.37%
+ Complexity 732 543 -189
============================================
Files 174 153 -21
Lines 3925 3040 -885
Branches 246 182 -64
============================================
- Hits 3718 2747 -971
- Misses 178 231 +53
- Partials 29 62 +33
Continue to review full report at Codecov.
|
19ef3e9
to
857992a
Compare
…t-shibboleth # Conflicts: # app/Http/Resources/ApplicationSettings.php # composer.json
…t-shibboleth # Conflicts: # app/Http/Kernel.php # app/Http/Resources/ApplicationSettings.php # composer.json # routes/api.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
|
||
<portType name="LogoutNotificationPortType"> | ||
<operation name="LogoutNotification"> | ||
<input message="getLogoutNotificationRequest"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
Closed in favor of #336 |
Fixes #20
Type (Highlight the corresponding type)
Checklist
Changes
Other information
Add this to the section of the vhost apache config: