Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend room id to support new greenlight room ids #144

Merged
merged 5 commits into from
Jun 1, 2021

Conversation

dsst95
Copy link
Contributor

@dsst95 dsst95 commented May 31, 2021

Fixes #143

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current masters head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Extended room id to support ids of new greenlight versions (e.g. xxx-xxx-xxx-xxx)

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #144 (64c845c) into master (f0e19ec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #144   +/-   ##
=========================================
  Coverage     91.77%   91.77%           
  Complexity      584      584           
=========================================
  Files           154      154           
  Lines          3235     3235           
  Branches        184      184           
=========================================
  Hits           2969     2969           
  Misses          204      204           
  Partials         62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0e19ec...64c845c. Read the comment docs.

@dsst95 dsst95 requested a review from SamuelWei May 31, 2021 17:13
@dsst95 dsst95 marked this pull request as ready for review May 31, 2021 17:13
@dsst95 dsst95 added the bug Something isn't working label May 31, 2021
@dsst95 dsst95 merged commit 28156c3 into master Jun 1, 2021
@SamuelWei SamuelWei deleted the 143-fix-import-from-newer-greenlight-versions branch November 4, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
PILOS
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Import from newer greenlight versions fails
2 participants