Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing custom URLs for legal notice and privacy policy #261

Merged

Conversation

AndreasThum
Copy link
Contributor

@AndreasThum AndreasThum commented Aug 25, 2022

Fixes #234

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current masters head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Customization options for legal notice url and privacy policy url in UI and .env (LEGAL_NOTICE_URL, PRIVACY_POLICY_URL)
  • Breaking: Legal notice url and privacy policy url internationalisation

Other information

none

@AndreasThum AndreasThum self-assigned this Aug 25, 2022
@AndreasThum AndreasThum linked an issue Aug 25, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Base: 96.19% // Head: 96.20% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b26c99e) compared to base (84afae4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
+ Coverage     96.19%   96.20%   +0.01%     
- Complexity      743      745       +2     
============================================
  Files           190      190              
  Lines          2839     2848       +9     
  Branches        246      248       +2     
============================================
+ Hits           2731     2740       +9     
  Misses          107      107              
  Partials          1        1              
Impacted Files Coverage Δ
app/Http/Requests/UpdateSetting.php 100.00% <ø> (ø)
resources/js/views/settings/Application.vue 100.00% <ø> (ø)
.../Http/Controllers/api/v1/ApplicationController.php 100.00% <100.00%> (ø)
app/Http/Resources/ApplicationSettings.php 100.00% <100.00%> (ø)
resources/js/components/FooterComponent.vue 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Some of the tests throw errors that I can't trace back to the changes made to the urls. Review required
…-configure-terms-of-service-imprint-and-dataprotection
resources/js/lang/en/settings.js Show resolved Hide resolved
resources/js/lang/en/settings.js Show resolved Hide resolved
resources/js/components/FooterComponent.vue Outdated Show resolved Hide resolved
@AndreasThum AndreasThum merged commit 0405ff6 into master Oct 12, 2022
@AndreasThum AndreasThum deleted the 234-configure-terms-of-service-imprint-and-dataprotection branch October 12, 2022 13:07
@SamuelWei SamuelWei changed the title implementing custom URLs for legal notice and privacy policy Implementing custom URLs for legal notice and privacy policy Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Terms of service, Imprint and Dataprotection
2 participants