Code has been fixed for swift 3. Fixed an issue for persistence. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 8, 2017 13:29
…sks from being persisted.
Please enter the commit message for your changes. Lines starting
…e, queuePriority. Removed dependencyStrs and let the operation handle the dependency by itself.
|
This is great @RajaveluC! Let me check out the diff and why the travis build is failing. |
sdgandhi
reviewed
Jul 9, 2017
| Deserializes tasks that were serialized (persisted) | ||
| */ | ||
| open func loadSerializedTasks() { | ||
| self.pause() |
| for task in tasks { | ||
| task.setupDependencies(tasks) |
There was a problem hiding this comment.
Why is this removed? It's important to setup the dependencies.
| @@ -158,8 +160,16 @@ public class SYNQueue : NSOperationQueue { | |||
| super.addOperation(op) | |||
| } | |||
|
|
|||
| func addDeserializedTask(task: SYNQueueTask) { | |||
| if tasksMap[task.taskID] != nil { | |||
| open func start() { | |||
There was a problem hiding this comment.
I'm not sure this and pause() should be open. What's a good argument for it?
| func log(level: LogLevel, _ msg: String) { | ||
| return ConsoleLogger.log(level, msg) | ||
| } | ||
| import Foundation |
| class func log(level: LogLevel, _ msg: String) { | ||
| runOnMainThread { print("[\(level.toString().uppercaseString)] \(msg)") } | ||
| public func log(_ level: LogLevel, _ msg: String) { | ||
| print("[\(level.toString())] \(msg)") |
There was a problem hiding this comment.
We lost the uppercase here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code has been fixed for swift 3. Fixed an issue that prevented the tasks from being persisted.