Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VENTUS][Configuration] Add some configuration #132

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[VENTUS][Configuration] Add some configuration #132

merged 1 commit into from
Jun 26, 2024

Conversation

Jules-Kong
Copy link
Collaborator

@Jules-Kong Jules-Kong commented Jun 26, 2024 •
edited
Loading

  1. Add the dockerfile of centos;
  2. Set codeowners;

@Jules-Kong Jules-Kong requested review from zhoujingya and wangqinfan and removed request for zhoujingya June 26, 2024 04:08
@zhoujingya
Copy link
Collaborator

@Jules-Kong我看了一下docker仓库，好像是有centos的，写这个dockerfile的用处？可以让user自己去dockerhub拉取吗？title修改一下。Add centos docker file？这样是不是更好一点

@Jules-Kong
Copy link
Collaborator Author

@Jules-Kong我看了一下docker仓库，好像是有centos的，写这个dockerfile的用处？可以让user自己去dockerhub拉取吗？title修改一下。Add centos docker file？这样是不是更好一点

出于合作方需要。原生的centos并不能直接使用。

@zhoujingya
Copy link
Collaborator

zhoujingya commented Jun 26, 2024 •
edited
Loading

image
运行不起来？@Jules-Kong

@Jules-Kong
Copy link
Collaborator Author

image 运行不起来？

你自己试着用一下？

@zhoujingya
Copy link
Collaborator

image 运行不起来？

你自己试着用一下？

build image了跑不起来

@zhoujingya
Copy link
Collaborator

跑起来了 @Jules-Kong

@Jules-Kong
[VENTUS][Configuration] Add some configuration
3581f12 
1. Add the dockerfile file of centos;
2. Set codeowners;
wangqinfan
wangqinfan approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@wangqinfan wangqinfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangqinfan wangqinfan merged commit ecddf38 into main Jun 26, 2024
1 check passed
@Jules-Kong Jules-Kong deleted the add-some-configuration branch June 27, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangqinfan wangqinfan wangqinfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jules-Kong @zhoujingya @wangqinfan