Updates for Sets and GSets support. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjaclark
requested changes
Apr 9, 2021
| @@ -519,8 +519,13 @@ Or we can see whether our gset includes a specific member: | |||
| ```java | |||
| // Using our "citiesSet" from above: | |||
There was a problem hiding this comment.
Is "citiesSet" still correct? Or should this now be "citiesGSet"?
| @@ -165,7 +165,7 @@ Let's create a Riak gset stored in the key `2019-11-17` in the bucket `account-1 | |||
| // before you perform operations on them: | |||
|
|
|||
| Location citiesSet = | |||
| new Location(new Namespace("sets", "travel"), "cities"); | |||
| new Location(new Namespace("gsets", "account-12345678"), "2019-11-17"); | |||
There was a problem hiding this comment.
I'd keep the gsets/travel/cities thing the same as from sets, as we add cities to it below.
| Set<BinaryValue> binarySet = response.getDatatype().view(); | ||
|
|
||
| System.out.println(binarySet.contains(BinaryValue.createFromUtf8("Vancouver"))); | ||
| System.out.println(binarySet.contains(BinaryValue.createFromUtf8("Ottawa"))); |
There was a problem hiding this comment.
Really requires a BinaryValue conversion for a string? Also, does it no longer work offline? Now requires a server fetch?
pjaclark
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.