Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying Docker build Erlang version #12

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Allow specifying Docker build Erlang version #12

merged 2 commits into from
Oct 14, 2023

Conversation

pataquets
Copy link

@pataquets pataquets commented Oct 13, 2023 •
edited
Loading 

docker build --build-arg erlang_version=24 ...

Defaults to currently used version on Dockerfile (25).

PR based on #11.

@pataquets pataquets mentioned this pull request Oct 13, 2023
Closed
@hmmr hmmr closed this Oct 14, 2023
@pataquets pataquets deleted the dockerfile--base-image-as-arg branch October 14, 2023 14:48
@pataquets pataquets restored the dockerfile--base-image-as-arg branch October 14, 2023 15:55
@pataquets
Copy link
Author

pataquets commented Oct 14, 2023 •
edited
Loading

@hmmr Since you provided an example use case on #10, I assumed this would be useful for that. I guess you declined it bc it's not needed.
Alternatively, you have #11 ready to review, which fixes the CMD issue also discussed.

@hmmr hmmr reopened this Oct 14, 2023
@hmmr hmmr merged commit cdf769d into TI-Tokyo:develop Oct 14, 2023
4 checks passed
@hmmr
Copy link

hmmr commented Oct 14, 2023

Did I close an issue without merging the underlying PR? Looks like I did. Corrected.

@pataquets pataquets deleted the dockerfile--base-image-as-arg branch October 14, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmmr hmmr hmmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pataquets @hmmr