Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move signal handle to main thread to make sure graceful shutdown work for docker container #99

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Move signal handle to main thread to make sure graceful shutdown work for docker container #99

merged 1 commit into from
Apr 25, 2018

Conversation

lixingwang
Copy link
Contributor

Fixes: # .

What kind of change does this PR introduce? (check one with "x")

[*] Bugfix
[] Feature
[] Code style update (formatting, local variables)
[] Refactoring (no functional changes, no api changes)
[] Other... Please describe:

What is the current behavior?
The graceful shutdown does not work in the docker container
What is the new behavior?
Working fine now.

@lixingwang lixingwang merged commit a29304a into master Apr 25, 2018
@fm-tibco fm-tibco deleted the docker-gracefull-shutdown branch August 7, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mellistibco mellistibco mellistibco approved these changes

@fm-tibco fm-tibco fm-tibco approved these changes

@vijaynalawade vijaynalawade Awaiting requested review from vijaynalawade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lixingwang @mellistibco @fm-tibco