Snap 3061 #1352
Merged
Snap 3061 #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumwale
approved these changes
Jul 26, 2019
|
For some reason, I am getting Exception with this change. The batch update fails. Not sure what wrong I am doing , as I am taking the lock in the begin tx part & releasing on commit/rollback |
…ent in ColumnarStore is in lower case, causing region not found exception. Fix is to upper case the table name. Not debugged why for some partitions the table name is coming in lower case
|
Looks like for some partition task, the table name is coming in lower case, causing the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The column table insert code takes a diskstore level read lock in the begin transaction & releases it in the commit or rollback.
The idea is that if the tx thread finds, that the standby oplog is in use, an InsufficientDiskSpaceException is thrown at oplog level to indicate the transaction to be rolledback. Also at oplog level when the oplog is switched to standby oplog, an asynchronous thread is started to shut the down the diskstore. This asynch thread seeks to take a write lock on the diskstore. The idea is that the diskstore should not be shut so long as any active transactions are not rolled back. Once the transaction is ended, the diskstore read lock is released, allowing the asynch diskstore shutdown thread to close the diskstore & regions using that diskstore.
Patch testing
Ran the store:check target.
Other PRs
store-change