Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automated test for ODBC FailOver functionality #1371

Merged
merged 8 commits into from
Jul 27, 2019
Merged

Conversation

bisenpiyush
Copy link
Contributor

@bisenpiyush bisenpiyush commented Jul 23, 2019

## Changes proposed in this pull request
Added automated test for ODBC Failover functionality

Patch testing

NA

ReleaseNotes.txt changes

NA

Other PRs

This PR linked to generated PR in snappy-store https://github.com/SnappyDataInc/snappy-store/pull/480

@bisenpiyush bisenpiyush requested a review from kneeraj July 23, 2019 14:10
Copy link

@kneeraj kneeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test for now looks ok. Please get the hydra test approved by either Sonal or Supriya.

One comment about the formatting.

Copy link
Contributor

@sonalsagarwal sonalsagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the conf for stopping the cluster mentioned in comments. Rest all LGTM.

@bisenpiyush bisenpiyush merged commit a8b31d0 into master Jul 27, 2019
@sumwale sumwale deleted the SNAP-2994 branch July 27, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants