Code changes for SNAP-2779 and SNAP-1338: #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding Redundancy column in Tables List to view count of redundant copies. - Adding Redundancy Status column in Tables List to monitor redundancy has been satisfied or broken. - Changes for maintaining Redundancy and isRedundancyImpaired details for count of redundant copies and redundancy satisfaction/broken status.
- Display Redundancy as 'NA' if distribution type is REPLICATE. - Display buckets count in Red color, if any of the buckets is offline.
kneeraj
approved these changes
Jul 26, 2019
| val numBuckets = tablePrRegion.getPartitionAttributes.getTotalNumBuckets | ||
| breakable { | ||
| for (i <- 0 until numBuckets) { | ||
| val idm = tablePrRegion.getNodeForBucketRead(i) |
There was a problem hiding this comment.
Test this for time. Use a schema which has multiple tables with a lot of buckets and please check the time it takes to complete all calls. Since this is going to be called for every run so we should check the cost of this.
For example take at least 100 tables with default number of bucket which means 12800 calls will be done.
There was a problem hiding this comment.
Acknowledged, will check it and will enhance the code in next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
copies and redundancy satisfaction/broken status.
Patch testing
ReleaseNotes.txt changes
Other PRs
Spark: TIBCOSoftware/snappy-spark#160
Store: TIBCOSoftware/snappy-store#495