Snap 3055 #1380
Merged
Snap 3055 #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshirish
reviewed
Jul 26, 2019
| SQLState.LANG_UNEXPECTED_USER_EXCEPTION, null, "Table retrieved successfully. To " + | ||
| "continue to drop this table change FORCE_DROP argument in procedure to true"); | ||
| throw new AnalysisException("Table retrieved successfully. To " + | ||
| "continue to drop this table change FORCE_DROP argument in procedure to true"); | ||
| } | ||
| } catch { | ||
| case a: AnalysisException if (a.message.contains("might be inconsistent in hive catalog")) => |
There was a problem hiding this comment.
It might be better to have the message stored in one constant and then use it at places where required. Or create a new exception of and catch it here.
dshirish
approved these changes
Jul 26, 2019
sumwale
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
review changes for previous changes
Patch testing
manually tested suite and failure scenarios
ReleaseNotes.txt changes
no
Other PRs
None