Generic support for INSERT/PUT ... VALUES with partial column spec #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use JDBCMutableRelation.executeUpdate consistently that correctly sets current schema instead of direct JDBC calls - for dropIndex when JDBCMutableRelation has not been resolved, SnappySession execution resolves the full table name before passing to dropRowStoreIndex - update SHOW INDEXES example output - minor formatting changes in ExternalStoreUtils and jdbcExtensions
Changes allow the following to be supported in addition to currently supported ones: // simple construct INSERT (INTO|OVERWRITE) <table> VALUES ... PUT INTO <table> VALUES ... // with partial columns that can be out of order with table definition INSERT (INTO|OVERWRITE) <table>(<col1>...) VALUES ... INSERT (INTO|OVERWRITE) <table>(<col1>...) SELECT ... PUT INTO <table>(<col1>...) VALUES ... PUT INTO <table>(<col1>...) SELECT ... - add SnappyParser "inlineTable" rule to insert/put and removed "subSelectQuery" rule that was specifically added to avoid the "inlineTable" rule - enhanced the AnalyzeMutableOperations rule to deal with the case of "partial columns" which is parsed as a TableValueFunction; locate the columns in target table and add appropriate Project on child - capture the query string for possible later use in "partial column" construct for row tables where explicit non-null DEFAULT value for a column may have been specified; for this case switch to DMLExternalTable which may fail if query contains Spark-only functions - removed custom PutIntoValuesColumnTable and use consistent way for both INSERT and PUT - also handle the QuestionMark case in VALUES() in a generic way as LocalRelation resolved by Spark - removed ResolveRelationsExtended and instead made table as proper child of DMLExternalTable so that it is resolved in the normal way by ResolveRelations
dshirish
reviewed
Aug 1, 2019
dshirish
approved these changes
Aug 1, 2019
No, ARRAY/STRUCT/MAP will work now in VALUES like they do in SELECT. |
also moved prepared put statement test from QueryRoutingDUnitTest to PreparedQueryRoutingSingleNodeSuite which is invoked by both scalatest and the dunit test
sumwale
force-pushed
the
master
branch
5 times, most recently
from
8b43301
to
2b254d9
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
232b75d
to
a2ab483
Compare
sumwale
force-pushed
the
master
branch
3 times, most recently
from
2c254f0
to
0f2888f
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
a466d26
to
ea127bd
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
99ec79c
to
c7b84fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes allow the following to be supported in addition to currently supported ones on all tables:
Changes proposed in this pull request
that was specifically added to avoid the "inlineTable" rule
which is parsed as a TableValueFunction; locate the columns in target table and
add appropriate Project on child
row tables where explicit non-null DEFAULT value for a column may have been specified;
for this case switch to DMLExternalTable which may fail if query contains Spark-only functions
so that it is resolved in the normal way by ResolveRelations
New unit tests to be added shortly.
Patch testing
precheckin
ReleaseNotes.txt changes
Document support for VALUES and partial column specification in INSERT/PUT. Limitation of
not being able to use Spark-only functions with partial column specification for ROW tables.
Other PRs
NA