Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retrieve_data(searchTerm = "DSM 319"…) yields error #45

Closed
katrinleinweber opened this issue Mar 20, 2018 · 1 comment
Closed

retrieve_data(searchTerm = "DSM 319"…) yields error #45

katrinleinweber opened this issue Mar 20, 2018 · 1 comment
Assignees
@katrinleinweber
Labels
bug

Comments

@katrinleinweber
Copy link
Collaborator

katrinleinweber commented Mar 20, 2018 •
edited

x[[1]][1]$url : $ operator is invalid for atomic vectors probably from interaction of

https://github.com/tibhannover/BacDiveR/blob/development/R/retrieve_data.R#L75

with

https://github.com/tibhannover/BacDiveR/blob/development/R/retrieve_data.R#L97-L103

  • try removing Rcurl and hand URL over to fromJSON directly
  • pass loop flag into download to switch off gsub for single downloads
@katrinleinweber katrinleinweber self-assigned this Mar 20, 2018
katrinleinweber added a commit that referenced this issue Mar 24, 2018
@katrinleinweber
Fix #45
cfc5507
katrinleinweber added a commit that referenced this issue Mar 24, 2018
@katrinleinweber
Fix #45
b5b5666
katrinleinweber added a commit that referenced this issue Apr 4, 2018
@katrinleinweber
Ensure that a single dataset is actually downloaded (really fixes #45)
0ba8789
katrinleinweber added a commit that referenced this issue Apr 18, 2018
@katrinleinweber
Ensure JSON download of single datasets (fix #45)
a403783
@katrinleinweber
Copy link
Collaborator Author

I meant #54 m-(

katrinleinweber added a commit that referenced this issue Sep 9, 2018
@katrinleinweber
Refactor testing of initially downloaded object (coverage up to 74%)
c40f967 
The test supposed to fix #45 was not actually working, because "culturecollectionno" & "sequence" searches returned NULL, which identical() didn't correctly compare with the "bacdive_id" retrieval result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrinleinweber katrinleinweber

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katrinleinweber