Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number before "Data download..." message & warn_slow_download() afterwards #84

Closed
2 tasks done
katrinleinweber opened this issue Jul 6, 2018 · 2 comments
Closed
2 tasks done
Assignees
Labels

Comments

@katrinleinweber
Copy link
Collaborator

I noticed the following problem....

dataset_Bss <- retrieve_data(searchTerm = "Bacillus subtilis subtilis")
 2 Data download in progress for BacDive-IDs: 1156 1157 1158 [...] Warning message:
In warn_slow_download(payload$count) :
  131 BacDive datasets are being downloaded... Please note: Depending on your internet connection speed, and the BacDive server load right now, this might take some time and may cause R(Studio) to become temporarily unresponsive. Maybe go for a walk for a few (I'm guessing: 0.5 to 0.7) minutes ;-)

On: R version 3.5.0 (2018-04-23); Platform: x86_64-w64-mingw32/x64 (64-bit).

I have...
@katrinleinweber katrinleinweber self-assigned this Jul 6, 2018
@katrinleinweber
Copy link
Collaborator Author

katrinleinweber commented Jul 31, 2018

The number must be the number of pages.

Same reason why there is a space in front of Data download...:

message(URLs_to_IDs(URL), " ", appendLF = FALSE)

But I can't move this to

message("Data download in progress for BacDive-IDs: ", appendLF = FALSE)
, because then it will not get executed for each dataset.

Maybe switch to a progress bar entirely, see #56?

@katrinleinweber
Copy link
Collaborator Author

katrinleinweber commented Sep 8, 2018

Also, warn_slow_download() is only called from retrieve_data(), not from retrieve_search_results() :-/

=> Create 1 unified message regardless of download size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant