Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn very specifically about slow downloads #56

Open
katrinleinweber opened this issue Apr 4, 2018 · 4 comments
Open

Warn very specifically about slow downloads #56

katrinleinweber opened this issue Apr 4, 2018 · 4 comments

Comments

@katrinleinweber
Copy link
Collaborator

katrinleinweber commented Apr 4, 2018

Instead of the general warning message in case of

https://github.com/tibhannover/BacDiveR/blob/a2d461dc35fc57c5cdf3b87fb6b2931869a6d507/R/retrieve_data.R#L56

always display a progress bar or "x % finished" message.

@katrinleinweber
Copy link
Collaborator Author

katrinleinweber commented Apr 4, 2018

@katrinleinweber
Copy link
Collaborator Author

MVP: reverse order of IDs to be downloaded, so that the messages count downwards. This would be a crude hack, but may sufficient as an initial progress bar.

@katrinleinweber
Copy link
Collaborator Author

Oh, no! Not just a crude hack, but a bad idea! IDs & URLs will be sorted alphabetical/lexically, which would move the 10, 100, etc. out of order. Rather than trying as.integer() and then try to keep IDs for naming aligned with URLs for downloading, I'd better only message about the lowest & highest ID. That way, users can gauge whether the download progress is nearing its end.

@katrinleinweber
Copy link
Collaborator Author

The above code has been moved to util-warn_slow_download.R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant