refactored event serializer: update to free event only if there are n…

.github/workflows/ci.yaml

@@ -41,6 +41,7 @@ jobs:
         run: |  
           touch .env
           echo "AZURE_STORAGE_CONNECTION_STRING=${{ secrets.AZURE_STORAGE_CONNECTION_STRING }}" >> .env
+          echo "VIPPS_MERCHANT_SERIAL_NUMBER=${{ secrets.VIPPS_MERCHANT_SERIAL_NUMBER }}" >> .env
 
       - name: Build the Stack
         run:  docker-compose build

app/content/exceptions.py

@@ -4,7 +4,12 @@
 
 class APIPaidEventCantBeChangedToFreeEventException(APIException):
     status_code = status.HTTP_400_BAD_REQUEST
-    default_detail = "Arrangementet er et betalt arrangement, og kan ikke endres til et gratis arrangement"
+    default_detail = "Arrangementet er et betalt arrangement med påmeldte deltagere, og kan ikke endres til et gratis arrangement"
+
+
+class APIEventCantBeChangedToPaidEventException(APIException):
+    status_code = status.HTTP_400_BAD_REQUEST
+    default_detail = "Arrangementet er et gratis arrangement med påmeldte deltagere, og kan ikke endres til et betalt arrangement"
 
 
 class APIUserAlreadyAttendedEvent(APIException):
@@ -48,3 +53,7 @@ class UnansweredFormError(ValueError):
 
 class EventIsFullError(ValueError):
     pass
+
+
+class RefundFailedError(ValueError):
+    pass

app/content/migrations/0054_registration_payment_expiredate.py

@@ -0,0 +1,18 @@
+# Generated by Django 4.2.5 on 2023-10-18 08:55
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("content", "0053_event_contact_person"),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="registration",
+            name="payment_expiredate",
+            field=models.DateTimeField(default=None, null=True),
+        ),
+    ]

app/content/migrations/0058_merge_20231217_2155.py

@@ -0,0 +1,13 @@
+# Generated by Django 4.2.5 on 2023-12-17 20:55
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("content", "0054_registration_payment_expiredate"),
+        ("content", "0057_event_emojis_allowed_news_emojis_allowed"),
+    ]
+
+    operations = []

app/content/models/event.py

@@ -108,6 +108,11 @@ def list_count(self):
         """Number of users registered to attend the event"""
         return self.get_participants().count()
 
+    @property
+    def has_participants(self):
+        """Returns if the event has users registered to attend the event"""
+        return self.list_count > 0
+
     @property
     def waiting_list_count(self):
         """Number of users on the waiting list"""

app/content/models/registration.py

@@ -4,6 +4,8 @@
 from django.db import models
 from django.db.models import Q
 
+from sentry_sdk import capture_exception
+
 from app.common.enums import StrikeEnum
 from app.common.permissions import BasePermissionModel
 from app.communication.enums import UserNotificationSettingType
@@ -17,7 +19,9 @@
 from app.content.models.event import Event
 from app.content.models.strike import create_strike
 from app.content.models.user import User
+from app.content.util.registration_utils import get_payment_expiredate
 from app.forms.enums import EventFormType
+from app.payment.util.order_utils import check_if_order_is_paid, has_paid_order
 from app.util import now
 from app.util.models import BaseModel
 from app.util.utils import datetime_format
@@ -36,6 +40,7 @@ class Registration(BaseModel, BasePermissionModel):
     is_on_wait = models.BooleanField(default=False, verbose_name="waiting list")
     has_attended = models.BooleanField(default=False)
     allow_photo = models.BooleanField(default=True)
+    payment_expiredate = models.DateTimeField(null=True, default=None)
     created_by_admin = models.BooleanField(default=False)
 
     class Meta:
@@ -86,7 +91,27 @@ def delete_submission_if_exists(self):
         )[:1]
         Submission.objects.filter(form=event_form, user=self.user).delete()
 
+    def refund_payment_if_exist(self):
+        from app.content.util.event_utils import refund_vipps_order
+
+        if not self.event.is_paid_event:
+            return
+
+        orders = self.event.orders.filter(user=self.user)
+
+        if has_paid_order(orders):
+            for order in orders:
+                if check_if_order_is_paid(order):
+                    refund_vipps_order(
+                        order_id=order.order_id,
+                        event=self.event,
+                        transaction_text=f"Refund for {self.event.title} - {self.user.first_name} {self.user.last_name}",
+                    )
+                    self.send_notification_and_mail_for_refund(order)
+
     def delete(self, *args, **kwargs):
+        from app.content.util.event_utils import start_payment_countdown
+
         moved_registration = None
         if not self.is_on_wait:
             if self.event.is_past_sign_off_deadline:
@@ -99,9 +124,26 @@ def delete(self, *args, **kwargs):
             moved_registration = self.move_from_waiting_list_to_queue()
 
         self.delete_submission_if_exists()
+
+        # TODO: Add this for refund
+        # self.refund_payment_if_exist()
+
         registration = super().delete(*args, **kwargs)
         if moved_registration:
             moved_registration.save()
+
+            if (
+                moved_registration.event.is_paid_event
+                and not moved_registration.is_on_wait
+            ):
+                try:
+                    start_payment_countdown(
+                        moved_registration.event, moved_registration
+                    )
+                except Exception as countdown_error:
+                    capture_exception(countdown_error)
+                    moved_registration.delete()
+
         return registration
 
     def admin_unregister(self, *args, **kwargs):
@@ -115,6 +157,7 @@ def admin_unregister(self, *args, **kwargs):
             moved_registration.save()
 
     def save(self, *args, **kwargs):
+
         if not self.registration_id:
             self.create()
 
@@ -208,6 +251,19 @@ def send_notification_and_mail(self):
                 self.event.pk
             ).send()
 
+    def send_notification_and_mail_for_refund(self, order):
+        Notify(
+            [self.user],
+            f'Du har blitt meldt av "{self.event.title}" og vil bli refundert',
+            UserNotificationSettingType.UNREGISTRATION,
+        ).add_paragraph(f"Hei, {self.user.first_name}!").add_paragraph(
+            f"Du har blitt meldt av {self.event.title} og vil bli refundert."
+        ).add_paragraph(
+            "Du vil få pengene tilbake på kontoen din innen 2 til 3 virkedager. I enkelte tilfeller, avhengig av bank, tar det inntil 10 virkedager."
+        ).add_paragraph(
+            f"Hvis det skulle oppstå noen problemer så kontakt oss på hs@tihlde.org. Ditt ordrenummer er {order.order_id}."
+        ).send()
+
     def should_swap_with_non_prioritized_user(self):
         return (
             self.is_on_wait
@@ -279,6 +335,12 @@ def move_from_waiting_list_to_queue(self):
                 registrations_in_waiting_list[0],
             )
             registration_move_to_queue.is_on_wait = False
+
+            if self.event.is_paid_event:
+                registration_move_to_queue.payment_expiredate = get_payment_expiredate(
+                    self.event
+                )
+
             return registration_move_to_queue
 
     def move_from_queue_to_waiting_list(self):

app/content/serializers/event.py

@@ -5,7 +5,10 @@
 
 from app.common.enums import GroupType
 from app.common.serializers import BaseModelSerializer
-from app.content.exceptions import APIPaidEventCantBeChangedToFreeEventException
+from app.content.exceptions import (
+    APIEventCantBeChangedToPaidEventException,
+    APIPaidEventCantBeChangedToFreeEventException,
+)
 from app.content.models import Event, PriorityPool
 from app.content.serializers.priority_pool import (
     PriorityPoolCreateSerializer,
@@ -176,36 +179,57 @@ def update(self, instance, validated_data):
         priority_pools_data = validated_data.pop("priority_pools", None)
         paid_information_data = validated_data.pop("paid_information", None)
         limit = validated_data.get("limit")
-        limit_difference = 0
-        if limit:
-            limit_difference = limit - instance.limit
+        instance_limit = instance.limit
 
         event = super().update(instance, validated_data)
 
+        self.update_queue(event, limit, instance_limit)
+
+        self.update_from_free_to_paid(event, paid_information_data)
+
+        self.update_from_paid_to_free(event, paid_information_data)
+
+        if len(paid_information_data):
+            self.update_paid_information(event, paid_information_data)
+
+        if priority_pools_data:
+            self.update_priority_pools(event, priority_pools_data)
+
+        event.save()
+        return event
+
+    def update_queue(self, event, limit, instance_limit):
+        if not limit:
+            return
+
+        limit_difference = limit - instance_limit
+
         if limit_difference > 0 and event.waiting_list_count > 0:
             event.move_users_from_waiting_list_to_queue(limit_difference)
 
         if limit_difference < 0:
             event.move_users_from_queue_to_waiting_list(abs(limit_difference))
 
+    def update_from_paid_to_free(self, event, paid_information_data):
         if paid_information_data and not event.is_paid_event:
+            if event.has_participants:
+                raise APIEventCantBeChangedToPaidEventException()
+
             PaidEvent.objects.create(
                 event=event,
                 price=paid_information_data["price"],
                 paytime=paid_information_data["paytime"],
             )
 
-        if event.is_paid_event and not len(paid_information_data):
-            raise APIPaidEventCantBeChangedToFreeEventException()
-
-        if len(paid_information_data):
-            self.update_paid_information(event, paid_information_data)
-
-        if priority_pools_data:
-            self.update_priority_pools(event, priority_pools_data)
+    def update_from_free_to_paid(self, event, paid_information_data):
+        if event.is_paid_event:
+            if not len(paid_information_data) and event.has_participants:
+                raise APIPaidEventCantBeChangedToFreeEventException()
 
-        event.save()
-        return event
+            paid_event = PaidEvent.objects.filter(event=event)
+            if paid_event:
+                paid_event.first().delete()
+                event.paid_information = None
 
     def update_priority_pools(self, event, priority_pools_data):
         event.priority_pools.all().delete()

app/content/serializers/registration.py

@@ -6,17 +6,18 @@
     DefaultUserSerializer,
     UserListSerializer,
 )
+from app.content.util.registration_utils import get_payment_expiredate
 from app.forms.enums import EventFormType
 from app.forms.serializers.submission import SubmissionInRegistrationSerializer
 from app.payment.enums import OrderStatus
-from app.payment.serializers.order import OrderSerializer
+from app.payment.util.order_utils import has_paid_order
+from app.payment.util.payment_utils import get_payment_order_status
 
 
 class RegistrationSerializer(BaseModelSerializer):
     user_info = UserListSerializer(source="user", read_only=True)
     survey_submission = serializers.SerializerMethodField()
     has_unanswered_evaluation = serializers.SerializerMethodField()
-    order = serializers.SerializerMethodField(required=False)
     has_paid_order = serializers.SerializerMethodField(required=False)
     wait_queue_number = serializers.SerializerMethodField(required=False)
 
@@ -31,7 +32,7 @@ class Meta:
             "created_at",
             "survey_submission",
             "has_unanswered_evaluation",
-            "order",
+            "payment_expiredate",
             "has_paid_order",
             "wait_queue_number",
             "created_by_admin",
@@ -44,20 +45,23 @@ def get_survey_submission(self, obj):
     def get_has_unanswered_evaluation(self, obj):
         return obj.user.has_unanswered_evaluations_for(obj.event)
 
-    def get_order(self, obj):
-        order = obj.event.orders.filter(user=obj.user).first()
-        if order:
-            return OrderSerializer(order).data
-        return None
-
     def get_has_paid_order(self, obj):
-        for order in obj.event.orders.filter(user=obj.user):
-            if (
-                order.status == OrderStatus.CAPTURE
-                or order.status == OrderStatus.RESERVE
-                or order.status == OrderStatus.SALE
-            ):
-                return True
+        orders = obj.event.orders.filter(user=obj.user)
+
+        if orders and (order := orders.first()).status == OrderStatus.INITIATE:
+            order_status = get_payment_order_status(order.order_id)
+            order.status = order_status
+            order.save()
+
+        return has_paid_order(orders)
+
+    def create(self, validated_data):
+        event = validated_data["event"]
+
+        if event.is_paid_event and not event.is_full:
+            validated_data["payment_expiredate"] = get_payment_expiredate(event)
+
+        return super().create(validated_data)
 
     def get_wait_queue_number(self, obj):
         if obj.is_on_wait:

app/content/tests/test_event_utils.py

@@ -0,0 +1,39 @@
+from datetime import timedelta
+
+import pytest
+
+from app.content.factories import EventFactory, RegistrationFactory
+from app.content.util.event_utils import get_countdown_time
+from app.payment.factories import PaidEventFactory
+
+
+@pytest.fixture()
+def paid_event():
+    return PaidEventFactory()
+
+
+@pytest.fixture()
+def event():
+    return EventFactory()
+
+
+@pytest.fixture()
+def registration(paid_event):
+    return RegistrationFactory(event=paid_event)
+
+
+@pytest.mark.django_db
+def test_that_paytime_countdown_adds_ten_minutes(paid_event):
+    """
+    Should return the countdown time of the event + 10 minutes.
+    """
+
+    paytime = paid_event.paytime
+    paytime_in_seconds = (paytime.hour * 60 + paytime.minute) * 60 + paytime.second
+
+    countdown_time = get_countdown_time(paid_event.event)
+
+    ten_minutes = timedelta(minutes=10)
+    ten_minutes_in_seconds = ten_minutes.seconds
+
+    assert countdown_time - paytime_in_seconds == ten_minutes_in_seconds