Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#1 Base migrations and models for Feedback #8

Merged
merged 8 commits into from
Feb 5, 2021
Merged

Feature/#1 Base migrations and models for Feedback #8

merged 8 commits into from
Feb 5, 2021

Conversation

chx2
Copy link
Contributor

@chx2 chx2 commented Feb 4, 2021

  • Added required models for feedback under config/feedback.php
  • Added Feedback migration with up/down methods
  • Added Feedback model
  • Added FeedbackFactory

@drewroberts the FeedbackFactory may need some additional refactoring. Most likely either/or:

  1. Update comments to reflect usage of $this->faker->boolean at the different steps
  2. Refactor to better walk through the different cases of user feedback

@chx2 chx2 added the question Further information is requested label Feb 4, 2021
@chx2 chx2 requested a review from drewroberts February 4, 2021 22:36
@drewroberts
Copy link
Member

I'm going to go ahead and merge this and then you can do the refactoring on the factory.

This package should also contain some commands that are in the main application.

drewroberts
drewroberts approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Chris. 🐠

@drewroberts drewroberts merged commit 84926d3 into main Feb 5, 2021
@drewroberts drewroberts deleted the chx2/feature/1-base-migrations-and-models branch February 5, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroberts drewroberts drewroberts approved these changes

Assignees
No one assigned
Labels
question Further information is requested
Projects
Modular Booking App
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chx2 @drewroberts