Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omnia/feature/25 add update models result ranking #41

Merged
merged 6 commits into from
Mar 5, 2021
Merged

Omnia/feature/25 add update models result ranking #41

merged 6 commits into from
Mar 5, 2021

Conversation

devjk1
Copy link
Contributor

@devjk1 devjk1 commented Mar 5, 2021

closes #25

  • added Result Model
  • added Model relationships: Ranking hasMany Result
  • added Model polymorphic relationships: Webpage and Place hasMany Result
  • modified Result migration: replaced nullable FK's for Webpage/Place with 'resultable_id' and 'resultable_type'

@devjk1 devjk1 requested a review from joshtorres March 5, 2021 20:24
@devjk1 devjk1 mentioned this pull request Mar 5, 2021
Open
drewroberts
drewroberts approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚤

@drewroberts drewroberts merged commit 3b454a1 into main Mar 5, 2021
@drewroberts drewroberts deleted the omnia/feature/25-add-update-models-result-ranking branch March 5, 2021 22:03
@alliroberts alliroberts added this to Done in SEO Tracking Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroberts drewroberts drewroberts approved these changes

@joshtorres joshtorres Awaiting requested review from joshtorres

Assignees
No one assigned
Labels
None yet
Projects
SEO Tracking
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Results
2 participants
@devjk1 @drewroberts