Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【建议】使用 GitHub Pages 搭载项目 #56

Closed
skyleaworlder opened this issue Feb 14, 2023 · 7 comments · Fixed by #64
Closed

【建议】使用 GitHub Pages 搭载项目 #56

skyleaworlder opened this issue Feb 14, 2023 · 7 comments · Fixed by #64
Labels
featrue new feature

Comments

@skyleaworlder
Copy link
Member

您有什么更好的想法吗

直接从 GitHub 看 README 太痛苦了,分享链接也是一长串,不如搭个 Pages。

详述目前的问题和可能的解决办法

Ref: https://zju-turing.github.io/TuringCourses/

您还有什么要说的吗

无。

@skyleaworlder skyleaworlder added the featrue new feature label Feb 14, 2023
@CookiePieWw
Copy link
Contributor

Sure its a good idea! I'd like to help, but there are still a lot of binary files in the repo (1.47GB!). I think its better to resolve this first.

@skyleaworlder
Copy link
Member Author

Sure its a good idea! I'd like to help, but there are still a lot of binary files in the repo (1.47GB!). I think its better to resolve this first.

Yes, you're right. It's totally my fault. About three years ago, I uploaded a large number of binaries. (since one of the original intentions of TJCS-Course was to gather certain hard-to-fetch materials, especially from mip246, which was extermely unstable at that time). I also uploaded a great number of verilog files. Although some measures were taken later (#4) to reduce the repo size from 2.1 GB to the current scale, it's still too large.

If you'd like to help, which is good and appreciated, you can refer to some websites (e.g. filter-branch) for guidance.

In general, times are changing, and the reasons from the past cannot be unconditionally extended into the future. I agree that it is necessary to delete aforementioned unnecessary files.

@CookiePieWw
Copy link
Contributor

CookiePieWw commented Nov 26, 2023

Yes, you're right. It's totally my fault. About three years ago, I uploaded a large number of binaries. (since one of the original intentions of TJCS-Course was to gather certain hard-to-fetch materials, especially from mip246, which was extermely unstable at that time). I also uploaded a great number of verilog files. Although some measures were taken later (#4) to reduce the repo size from 2.1 GB to the current scale, it's still too large.

Understood. I'd rather thank you for your initial intentions to create this. It helped me a lot.

If you'd like to help, which is good and appreciated, you can refer to some websites (e.g. filter-branch) for guidance.

Got it. Since it's not closely related to this issue, I'll open another one focusing on the binary files.

@CookiePieWw
Copy link
Contributor

Hi @skyleaworlder, I tried to make the repo ready for github pages here, using github actions and mkdocs refering this repo. The gh-pages branch will be reconstructed on pushes.

You can go through the pages locally like this:

  1. Clone the repo and checkout to mkdocs branch
  2. Run python ./mkdocs.py to migrate files for mkdocs
  3. Install mkdocs and mkdocs-material using pip
  4. run mkdocs serve

The page will be deployed on http://127.0.0.1:8000/ by default.

@skyleaworlder
Copy link
Member Author

Hi @skyleaworlder, I tried to make the repo ready for github pages here, using github actions and mkdocs refering this repo. The gh-pages branch will be reconstructed on pushes.

You can go through the pages locally like this:

  1. Clone the repo and checkout to mkdocs branch
  2. Run python ./mkdocs.py to migrate files for mkdocs
  3. Install mkdocs and mkdocs-material using pip
  4. run mkdocs serve

The page will be deployed on http://127.0.0.1:8000/ by default.

Great job! Thanks for your dedicated contribution first. I'd like to ask if this web page has been successfully deployed in your repository? I tried accessing https://cookiepieww.github.io/TJCS-Course/ but received a 404 error.

Additionally, I'd like to mention that the current repository structure uses "<course-code>_<course-name>" and keeps them together in the root directory to account for potential changes in the curriculum. While it is possible for the course code and name to change, typically when that happens, the course also undergoes a change in its evaluation system.

@CookiePieWw
Copy link
Contributor

Great job! Thanks for your dedicated contribution first. I'd like to ask if this web page has been successfully deployed in your repository? I tried accessing https://cookiepieww.github.io/TJCS-Course/ but received a 404 error.

Sry, it seems I closed it while fixing the workflows. It should work now.

Additionally, I'd like to mention that the current repository structure uses "<course-code>_<course-name>" and keeps them together in the root directory to account for potential changes in the curriculum. While it is possible for the course code and name to change, typically when that happens, the course also undergoes a change in its evaluation system.

Got it. I think it is better to make a hierarchy structure on website, so classifying the courses with a config file (instead of directories) seems to be an acceptable solution, which can keep the current structure while generating the hierarchy structure. What do you think about it?

@skyleaworlder
Copy link
Member Author

Great! I can see the deployment now, which looks good. (However, many of the contents inside were written during my undergraduate years, and now they feel quite embarrassing.

And I agree with your perspective on the organization of the repository directory. Of course you can create a new PR and refactor the current repository structure to a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
featrue new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants