Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default math font; ci; README #28

Merged
merged 3 commits into from
May 15, 2023
Merged

fix: default math font; ci; README #28

merged 3 commits into from
May 15, 2023

Conversation

RizhongLin
Copy link
Member

@RizhongLin RizhongLin commented May 15, 2023

Summary of this PR

Several users of our codebase have raised inquiries regarding math fonts. They have observed discrepancies between the math fonts utilized in this template and the purported "default" math fonts.

Consequently, I have made modifications to the following code:

\usepackage{ifthen}
\newboolean{useTimesNewRoman}
\setboolean{useTimesNewRoman}{false} % Set to false if you don't want to use Times New Roman 
                                     % or if you want to use the default math font (Latin Modern) for math symbols
\ifthenelse{\boolean{useTimesNewRoman}}{%
  \usepackage{amsmath,amsthm,amsfonts,amssymb,amscd}%
  \usepackage{fontspec}%
  \setmainfont{Times New Roman}%
}{%
  \usepackage{amsthm,amscd}%
  \usepackage{newtxtext,newtxmath}%
}

Hence, as indicated in the comments, if you desire to employ Times New Roman instead of Adobe New Roman, or if you wish to utilize the "default" math font, you can set the useTimesNewRoman variable to true.

If you have any suggestions or questions, please feel free to share them in the GitHub Discussions.

Should the successful integration of this PR lead to the closure of certain issues?

The specific issues discussed privately on QQ. In the future, it would be preferable to address such matters through GitHub Discussions. 馃憤馃徎

@RizhongLin RizhongLin merged commit 03ad882 into master May 15, 2023
8 of 12 checks passed
@RizhongLin RizhongLin deleted the fix-ci branch May 15, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant