Skip to content

Commit

Permalink
ArchUnitTestEngine.uniqueId should not start with 'junit-', since tha…
Browse files Browse the repository at this point in the history 
…t prefix is owned by the JUnit team.

Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
  • Loading branch information
@codecholeric
codecholeric committed Aug 20, 2018
1 parent 7d53a46 commit 456a60c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ...unit-junit/junit5/engine/src/main/java/com/tngtech/archunit/junit/ArchUnitTestEngine.java
View file
Expand Up @@ -64,7 +64,7 @@
*/
@Internal
public final class ArchUnitTestEngine extends HierarchicalTestEngine<ArchUnitEngineExecutionContext> {
static final String UNIQUE_ID = "junit-archunit";
static final String UNIQUE_ID = "archunit";

private SharedCache cache = new SharedCache(); // NOTE: We want to change this in tests -> no static/final reference

Expand Down

3 comments on commit 456a60c

@sormuras
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

JUnit Platform 1.3.0-SNAPSHOT now emits a warning for ArchUnit 0.9.1

09:24:09.430 [Test worker] WARN  org.junit.platform.launcher.core.DefaultLauncher
Third-party TestEngine implementations are forbidden to use the reserved 'junit-' prefix for their ID: 'junit-archunit'

https://travis-ci.org/junit-team/junit5/jobs/422937234#L2166

This commit will make the warning vanish.

@sormuras
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning is the last one remaining in our build:

https://travis-ci.org/junit-team/junit5/jobs/447525671#L1396

Is releasing ArchUnit 0.9.2 soon ... an idea?

@hankem
Copy link
Member

@hankem hankem commented on 456a60c Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could have 0.9.2 (including a fix for #117) released next week when @codecholeric is back from vacation.

Please sign in to comment.