Adding tests to verify patterns are not followed

[jamietanna]

As a follow-up to #774, it now is not as easy to write a rule that verifies that we do not follow a pattern, such as the below which ensures we don't use field injection with Spring's Dependency Injection:

  @ArchTest
  void requireNoAutowiredFieldInjection(JavaClasses classes) {
    classesThatAreNotTests()
        .and()
        .containAnyFieldsThat(
            describe(
                "are Autowired by Spring",
                f -> f.tryGetAnnotationOfType(Autowired.class).isPresent()))
        .should()
        .containNumberOfElements(equalTo(0))
        .check(classes);
  }

This now would require running the whole set of tests with archRule.failOnEmptyShould which although fine, leads to the risk that we have other tests that need to assert i.e. .containNumberOfElements(greaterThan(0)).

[codecholeric]

Thanks for raising the issue 🙂 Yes, I understand that we need to make this configurable per rule! We will tackle this ASAP! (see #808 and #806)