Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support optional component keyword in PlantUML diagram rules #1223

Merged

Conversation

tfij
Copy link
Contributor

@tfij tfij commented Jan 2, 2024

It is valid PlantUML syntax to prepend the component keyword to a component
declaration, e.g.

component [MyComponent] <<..mycmp..>>

Since it doesn't create a big overhead to support this as an optional part
of the component declaration, we can add it to make it easier for users
that distinguish their components from other types of objects like databases.

@tfij
Copy link
Contributor Author

tfij commented Jan 2, 2024

PR should be rebased after the #1184 merge so it will contain only a single commit

It is valid PlantUML syntax to prepend the `component` keyword to a component
declaration, e.g.

```
component [MyComponent] <<..mycmp..>>
```

Since it doesn't create a big overhead to support this as an optional part
of the component declaration, we can add it to make it easier for users
that distinguish their components from other types of objects like databases.

Signed-off-by: Tomasz Fijalkowski <3066563+tfij@users.noreply.github.com>
@codecholeric codecholeric force-pushed the plantuml-support-optional-component-keyword branch from 39190ba to 2ec2db2 Compare April 10, 2024 21:46
@codecholeric codecholeric changed the title Plantuml support optional component keyword support optional component keyword in PlantUML diagram rules Apr 10, 2024
Copy link
Collaborator

@codecholeric codecholeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot for your contribution 😃

@codecholeric codecholeric merged commit 6fda869 into TNG:main Apr 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants