-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@As not considered in overridden stage method #247
Comments
I currently cannot reproduce the issue. I guess, however, that it is related to #63. Which Java version did you use? |
Also related: #193 |
Just to validate: could you make the super-class non-abstract and test whether it works then? |
I remembered that I've encountered something similar, but I didn't remember where. The used Java version is 1.8.0_72. Dropping the abstract from both RelatedToProjectSecurityTest and RelatedToProjectSecurityStage didn't solve the issue, the report is still not correct. UPDATE: I've just realized that the provided code snippet does not reflect the situation properly. The overridden method is abstract as well - but I've also ensured that the issue is not related to the abstract method. When I have a look at your test case, my abstract stage extends from JAFCrudTestStage which is not abstract, and this class also extends from another non-abstract class which again extends... there is a 3-4 level inheritance structure behind my abstract stage class. Maybe the issue is related to that. |
Ok, I see. I will try to play around a bit to see whether I can reproduce the issue. |
Ok. I could reproduce the issue as follows, but I do not know, whether this is what you meant:
When I now use |
I'm not sure this is worth implementing. Why not have the annotated step method in the super class which accesses abstract methods for the subclass to implement? |
Well, the implementation should not be too hard and I also see that the current behavior is surprising and seems to be wrong from a users point of view. |
So should this work for interface methods too then? |
Good point :-) |
If it should work for interfaces as well you'll run into the interesting situation of having multiple interfaces defining the same method but using different |
Yes, this is exactly what I mean :) |
Cool. For now, I will only implement this feature for super classes, not interfaces. Supporting interfaces opens too many questions ;-) |
which is used in
When I execute ProjectSecurityTest, I expect the following report:
but instead,
is generated. So it seems that the @as is not recognized in this case.
Best regards,
Niko
The text was updated successfully, but these errors were encountered: