Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven plugin doesn't create report with default settings #276

Closed
ahus1 opened this issue Dec 25, 2016 · 7 comments
Closed

Maven plugin doesn't create report with default settings #276

ahus1 opened this issue Dec 25, 2016 · 7 comments
Milestone

Comments

@ahus1
Copy link
Contributor

ahus1 commented Dec 25, 2016

In 0.12.1 when you used the maven plugin a HTML5 report was created by default when no format was given. With 0.13.0 when no format is given no report is created at all. No warning is given. The actual console output is given as shown below, but no report has actually been created.

[INFO] --- jgiven-maven-plugin:0.13.0:report (default-cli) @ *** ---
[INFO] JGiven HTML report source directory: ***
[INFO] JGiven HTML report output directory: ***
[INFO] Generating HTML reports to ***
[INFO] -------------------------------------------------------------------
[INFO] Generated JGiven HTML reports to directory ***

I quick search for the origin of this changed behavior in 0.13.0 revealed no clue for me what commit changed the behavior.

Expected behavior (to be discussed):

  • when no configuration for the format of the report is given, a HTML5 report should be created
  • when a format is given in the configuration that is not recognized, an error should be shown

BTW: When you pass null as a format to ReportGenerator#generate() no report will be created. Is that a feature or a bug?

@janschaefer
Copy link
Contributor

janschaefer commented Dec 25, 2016

I will have a look. I agree with the expected behavior :-)

@ahus1
Copy link
Contributor Author

ahus1 commented Dec 25, 2016

If you could have a second look for the commit that lead to the changed behavior, I'm happy to provide a fix via PR to update the maven plugin (if you have time to wait a few days)

@janschaefer
Copy link
Contributor

This is really mysterious. Actually the default value is 'html'. The only explanation I have is that v0.13.0 might have been built with a different Maven version and that the behavior of Maven has changed. I will check that.

@janschaefer janschaefer added this to the v0.13.1 milestone Dec 25, 2016
@janschaefer
Copy link
Contributor

I don't know what exactly the problem was, but I guess it was the use of the deprecated expression in the Maven Plugin.

@janschaefer
Copy link
Contributor

I will publish a 0.13.1 version with the fix as soon as possible

@janschaefer
Copy link
Contributor

v0.13.1 is released, could you verify that it works for you now?

@ahus1
Copy link
Contributor Author

ahus1 commented Dec 25, 2016

v0.13.1 works as expected: no configuration produces a HTML5 report. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants