Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #318 #319

Merged
merged 3 commits into from Jun 15, 2017
Merged

fix #318 #319

merged 3 commits into from Jun 15, 2017

Conversation

dgrandemange
Copy link
Contributor

@dgrandemange dgrandemange commented May 27, 2017 •
edited

  • fix POJOAnnotationFormatter to return literal string "null" when given object is null
  • complete datatable examples to test this behavior
  • migrate datatable examples model/format/annotation classes from src/test/java to src/main/java

TNG#318
53a525d 
fix POJOAnnotationFormatter to return literal string "null" when given
object is null
complete datatable examples to test this behavior
migrate datatable examples model/format/annotation classes to src/main
@dgrandemange dgrandemange mentioned this pull request May 27, 2017
Closed
TNG#318
411b1f3 
jgiven-examples : add compile dependency to jgiven-core
@dgrandemange dgrandemange changed the title #318 fix fix #318 May 28, 2017
@janschaefer
Copy link
Contributor

Thank you for the pull request! The build currently fails, however, because you use the Objects.isNull method from JDK 8. JGiven, however, is currently backwards compatible until Java 6. Could you fix that?

TNG#318
1510efc 
java 1.6 compatibility
@dgrandemange
Copy link
Contributor Author

Hi,

Got it.
Actually, the Gradle Eclipse integration plugin i use didn't show any compile errors in the jgiven-core module. So this explains that.

Anyway, it should be ok by now.

@janschaefer janschaefer merged commit 1061c61 into TNG:master Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgrandemange @janschaefer