Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use base-64 encoding without padding #145

Merged
merged 1 commit into from Jul 4, 2023
Merged

use base-64 encoding without padding #145

merged 1 commit into from Jul 4, 2023

Conversation

nbaars
Copy link

@nbaars nbaars commented Jun 26, 2023

The spec states (see https://datatracker.ietf.org/doc/html/rfc7515#appendix-C) that all trailing '=' characters should be omitted.

Resolves #144

Copy link
Contributor

@ostrya ostrya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the formatting issues (see CI result), otherwise looks good.

The spec states (see https://datatracker.ietf.org/doc/html/rfc7515#appendix-C) that all trailing '=' characters should be omitted.

Resolves TNG#144

Signed-off-by: Nanne Baars <nanneb@gmail.com>
@nbaars
Copy link
Author

nbaars commented Jul 4, 2023

@ostrya fixed, checks should pass now

@ostrya ostrya merged commit 9a11e42 into TNG:main Jul 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base64 encoding issue when processing JWKS due to trailing '=' characters
2 participants