remove special behavior for single target creation

TOMToolkit · Nov 3, 2023 · ae0e3a3 · ae0e3a3
1 parent e521f40
commit ae0e3a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/tom_alerts/tests/tests.py b/tom_alerts/tests/tests.py
@@ -228,7 +228,7 @@ def test_create_target(self):
         response = self.client.post(reverse('tom_alerts:create-target'), data=post_data)
         self.assertEqual(Target.objects.count(), 1)
         self.assertEqual(Target.objects.first().name, 'Hoth')
-        self.assertRedirects(response, reverse('tom_targets:update', kwargs={'pk': Target.objects.first().id}))
+        self.assertRedirects(response, reverse('tom_targets:list'))
 
     @override_settings(CACHES={
             'default': {

diff --git a/tom_alerts/views.py b/tom_alerts/views.py
@@ -300,16 +300,9 @@ def post(self, request, *args, **kwargs):
             except IntegrityError:
                 messages.warning(request, f'Unable to save {target.name}, target with that name already exists.')
                 errors.append(target.name)
-        if (len(alerts) == len(errors)):
+        if len(alerts) == len(errors):
             return redirect(reverse('tom_alerts:run', kwargs={'pk': query_id}))
-        elif (len(alerts) == 1):
-            return redirect(reverse(
-                'tom_targets:update', kwargs={'pk': target.id})
-            )
-        else:
-            return redirect(reverse(
-                'tom_targets:list')
-            )
+        return redirect(reverse('tom_targets:list'))
 
 
 class SubmitAlertUpstreamView(LoginRequiredMixin, FormMixin, ProcessFormView, View):