Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/basic finder chart #263

Merged
merged 11 commits into from
Mar 30, 2020
Merged

Feature/basic finder chart #263

merged 11 commits into from
Mar 30, 2020

Conversation

eheinrich
Copy link
Contributor

Adds basic finder chart annotations to the aladin viewer on the target details page.

Additions include:

  • Set the field of view
  • Circle the target on the aladin image
  • Compass drawn on the aladin image
  • Scale bar of configurable size drawn on the aladin image
  • Ability to save the resulting image

This only applies to sidereal targets. I also excluded the aladin viewer from being displayed for non-sidereal targets because it does not work with those target types.

Between a range of declinations from -85 to 85 degrees, within which most targets are expected to reside, the finder chart annotations look nice and clean. Outside of that range, as the target approaches a pole, they start getting more and more lopsided. This is a general issue when working close to the poles, and seeing as it probably will not affect most targets, I think it can be addressed at a later date to improve the annotations when close to the poles.

I made sure the style of the UI elements that were added match the look and feel of the rest of the target details page.

Here is a finder chart that was generated with this branch for m88, with a field of view of 10 arcmin.
m88_10arcminFOV

Copy link
Contributor

@dmcollom dmcollom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! The only thing I think we should do is briefly document the feature somewhere in the docs. Just updating the docstring for the Aladin templatetag to note the other features should be sufficient, but @rachel3834 may have other thoughts on that.

As a side note (and completely not your problem), the templatetag docs don't seem to be generating correctly in readthedocs, but they do locally for me. So if you make that change and don't see it reflected on RTD...don't worry about it, I guess.

@dmcollom dmcollom changed the base branch from development to master March 30, 2020 18:55
@dmcollom dmcollom changed the base branch from master to development March 30, 2020 19:22
@dmcollom dmcollom changed the base branch from development to master March 30, 2020 19:22
@dmcollom dmcollom changed the base branch from master to development March 30, 2020 19:27
@dmcollom dmcollom changed the base branch from development to master March 30, 2020 19:58
@dmcollom dmcollom merged commit 67000a3 into master Mar 30, 2020
@dmcollom dmcollom deleted the feature/basic-finder-chart branch March 30, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants