Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow nondetections in photometry uploads #664

Merged
merged 2 commits into from Jun 30, 2023
Merged

allow nondetections in photometry uploads #664

merged 2 commits into from Jun 30, 2023

Conversation

griffin-h
Copy link
Contributor

@griffin-h griffin-h commented May 22, 2023 •
edited

This removes masked values before storing uploaded photometry data, so that some rows in the table can be detections and others can be nondetections.

I also piped through an optional 'source' column to the source_name attribute of the ReducedDatum.

I modified the photometry_sample.csv file to show examples of both these changes.

@jchate6 jchate6 self-requested a review June 30, 2023 22:14
jchate6
jchate6 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@jchate6 jchate6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this.

@jchate6 jchate6 merged commit 6ffd144 into TOMToolkit:dev Jun 30, 2023
12 checks passed
@griffin-h griffin-h deleted the feature/upload_limits branch June 30, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchate6 jchate6 jchate6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
TOM Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@griffin-h @jchate6