Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the instruction on tdp deploy #61

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

morihuang
Copy link
Contributor

@morihuang morihuang commented Nov 17, 2023

Which issue(s) this PR fixes

Additional comments

When running tdp deploy --targets prometheus_init,grafana_init, there will be an error message: Error: No such option: --targets. And since tdp-lib has been updated, the instruction might be changed accordingly as this commit suggests.

Agreements

@morihuang morihuang marked this pull request as ready for review November 24, 2023 13:56
@rpignolet
Copy link
Contributor

Can you switch to lowercase for "docs" in your commit message please ?

@morihuang morihuang changed the title Docs: update the instruction on tdp deploy docs: update the instruction on tdp deploy Nov 24, 2023
@morihuang
Copy link
Contributor Author

morihuang commented Nov 24, 2023

Can you switch to lowercase for "docs" in your commit message please ?

thx for the reminder, will update now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants