Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move *_log_dir and *_log_file to tdp_cluster.yml #81

Conversation

giem-git
Copy link
Contributor

Which issue(s) this PR fixes

Fixes #79

Additional comments

note : In addition, grafana_logs_dir has been renamed to grafana_log_dir to ensure uniform naming with other components.

@giem-git giem-git self-assigned this Jan 22, 2024
@giem-git giem-git force-pushed the 79-refactor-_log_dir-and-_log_file-variables-should-be-moved-to-tdp_cluster branch from c308875 to 6704497 Compare January 26, 2024 16:17
@giem-git giem-git marked this pull request as draft January 26, 2024 16:20
@giem-git giem-git marked this pull request as ready for review January 26, 2024 16:44
@rpignolet rpignolet merged commit a1c1b46 into main Feb 2, 2024
3 checks passed
@rpignolet rpignolet deleted the 79-refactor-_log_dir-and-_log_file-variables-should-be-moved-to-tdp_cluster branch February 2, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: *_log_dir and *_log_file variables should be moved to tdp_cluster
3 participants