-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report creation script #61
Conversation
31983d9
to
e95d369
Compare
package.json
Outdated
@@ -79,6 +79,7 @@ | |||
"postinstall": "husky install", | |||
"prepack": "pinst --disable", | |||
"postpack": "pinst --enable", | |||
"init-report": "node scripts/initReport.mjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Scripts are located inside
bin
- the entry point shall be the foundation of a future scalable API without backward incompatibilities, the entry point shall be generatic, eg
npx tdp <command> <args>
(use Shell.js) - the command,
initReport
shall accept additional commands as part of a more complex API,report init
and notinit report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Scripts are located inside
bin
All other TOSIT-IO project use a scripts
directory. I think it's best to do the same here.
- the entry point shall be the foundation of a future scalable API without backward incompatibilities, the entry point shall be generatic, eg npx tdp (use Shell.js)
- the command, initReport shall accept additional commands as part of a more complex API, report init and not init report
This is a simple script that I share for convenience. If we want to build a whole CLI I suggest we do it in a next iteration.
I renamed the script to reportinit
.
Thanks @PaulFarault, I'm not able to review code but feature is very useful ! |
e6e4efb
to
2d9b33d
Compare
2d9b33d
to
f950c1c
Compare
Provide a script to easily create new meeting notes reports.
Usage
Result
Create a
yymmdd-contributors.md
file on a newyymmdd-contributors-report
branch containing a template populated with the pending PRs. For example: