Add optional Citus support #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tcl files in this repo did not seem to adhere to any common indentation style. This made it quite hard for me to understand what the code was doing. To resolve this I used the reformat.tcl script that is provided on the tcl wiki: https://wiki.tcl-lang.org/page/Reformatting+Tcl+code+indentation I replaced the original reformat proc that was provided in the first message, with the reformat2 proc that was contributed by aplsimple in the last message on the thread. I did make one final change to this reformat2 script, such that does not exclude comments from indentation. I think this makes the code much more readable. I understand that this is a big PR, but it only changes whitespace. If you look at the diff by excluding whitespace, there's only one change. And this change is a change from file encoding from latin1 to utf-8.
JelteF
force-pushed
the
add-citus-support
branch
from
ba4caad
to
91c40e4
Compare
This adds the option to configure the TPROC-C build step to build the schema with support for Citus. This distributes the tables and all the stored procedures.
JelteF
force-pushed
the
add-citus-support
branch
from
91c40e4
to
a9d8a84
Compare
|
I have tested this and created a pull requests citusdata#4 to fix a minor issue with the GUI options when the citus data checkbox is selected in the GUI options. I have also tested the schema build and creation without the citus data options selected to verify that the regular PostgreSQL builds continue to work as before. |
|
Merging Pull Request as voted on by TPC-OSS subcommittee on 11th Jan 2022. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR includes the #292, to make it more readable and make merging them
both in the future easier. Adding comments to the diff is probably easier to do
on this equivalent PR with a different base branch on the Citus repo: citusdata#2
This adds the option to configure the TPROC-C build step to build the
schema with support for Citus. This distributes the tables and all the
stored procedures.