Deprecate CLI runtimer #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
This was
linked to
issues
Aug 17, 2022
Closed
|
Pull request also changes the default workload to timed from test as this is often the default especially when running from the CLI. |
abondvt89
approved these changes
Aug 23, 2022
memmertoIBM
approved these changes
Aug 23, 2022
| @@ -54,7 +54,8 @@ proc TclReadLine::setup_prompt_requirements {} { | |||
| package require Expect | |||
| interp alias {} stty {} exp_stty | |||
| # Prevent sigint from killing our shell: | |||
There was a problem hiding this comment.
This comment is now out of date.
|
Merging after reviews and approval of the three members of the code maintenance team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request addresses issues #387 #403 and fixes #414 allowing a simpler command line script such as the following to run a basic timed workload automating loadscript, vucreate and runtimer.
The PR automates loadscript for the CLI as per #403 however only if there is no script loaded at all. The script could be refreshed for each run when vucreate is run however if customscript has been used then it would always be overwritten, therefore any existing script will be retained.
if loadscript, vucreate and runtimer are used they continue to work as before apart from runtimer and waittocomplete that print messages that the command is deprecated.
As the timers are now automated Ctrl-C will be permitted in interactive mode as well as scripted.