-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drop schema functionality #430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memmertoIBM
suggested changes
Sep 15, 2022
I have tested and the -c flag is the one that works. Using -i only leaves the first window open and does not run the drop command.
I have tested and the -c flag is the one that works. Using -i only leaves the first window open and does not run the drop command.
memmertoIBM
approved these changes
Sep 16, 2022
abondvt89
approved these changes
Sep 22, 2022
Merging after reviews and approval of the three members of the code maintenance team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #351
Adds GUI Icon and CLI command to drop the schema created by Build Schema.
For Db2 functionality is added by running external command. To do this correctly we need to add the sqlecrea and the sqledrpd APIs to db2tcl and then we can both create and drop the schema from within HammerDB.