Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI diset error message #437

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

sm-shaw
Copy link
Contributor

@sm-shaw sm-shaw commented Sep 23, 2022

Change CLI diset error message so if incorrect dictionary is given, error message reports the dictionary that the key is in or reports that the key is not in any dictionary.

steve@CRANE:/opt/HammerDB-4.5$ ./hammerdbcli
HammerDB CLI v4.5
Copyright (C) 2003-2022 Steve Shaw
Type "help" for a list of commands
hammerdb>dbset db mysql
Database set to MySQL

hammerdb>diset tpcc mysql_ssl true
Dictionary "tpcc" for MySQL exists but key "mysql_ssl" doesn't, key "mysql_ssl" is in the "connection" dictionary
Type "print dict" for valid dictionaries and keys for MySQL

hammerdb>diset connection mysql_ssl true
Changed connection:mysql_ssl from false to true for MySQL

hammerdb>diset connection mysql_sst true
Dictionary "connection" for MySQL exists but key "mysql_sst" doesn't, key "mysql_sst" cannot be found in any MySQL dictionary
Type "print dict" for valid dictionaries and keys for MySQL

hammerdb>

@sm-shaw sm-shaw requested a review from a team as a code owner September 23, 2022 13:22
@sm-shaw sm-shaw linked an issue Sep 23, 2022 that may be closed by this pull request
@abondvt89
Copy link
Contributor

Merging after reviews and approval of the three members of the code maintenance team.

@abondvt89 abondvt89 merged commit fa9e267 into TPC-Council:master Sep 27, 2022
@sm-shaw sm-shaw deleted the 436 branch November 23, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set mysql_ssl and mysql_ssl_two_way to true
3 participants